[PATCH] D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS
Peter Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 14 01:49:59 PST 2020
peter.smith added a comment.
In D93045#2449509 <https://reviews.llvm.org/D93045#2449509>, @zatrazz wrote:
> Updated patch based on previous comments. For in.relaIplt / R_AARCH64_IRELATIVE
> I decided to not include since it seems to what binutils is done currently. I will raise with
> them if this is the intended behaviour or if R_AARCH64_IRELATIVE should also create
> the dynamic tag (and fix is accordingly on lld if it were the case).
As I understand it, IRELATIVE relocations are not resolved lazily by the dynamic loader so there would not need to be a variant PCS flag in this particular case. So I think it is likely binutils is right here. No harm in checking though.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93045/new/
https://reviews.llvm.org/D93045
More information about the llvm-commits
mailing list