[PATCH] D91336: AMDGPU/GlobalISel: Fix negative offset folding for buffer_load

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:1324
 
+static bool signBitNotSet(unsigned Val) { return (Val & 0x80000000) == 0; }
+
----------------
arsenm wrote:
> Shouldn't use unsigned here
I don't think we need this function at all. Surely `(int)Val >= 0` is clear enough?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91336/new/

https://reviews.llvm.org/D91336