[PATCH] D91336: AMDGPU/GlobalISel: Fix negative offset folding for buffer_load

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 14 07:28:15 PST 2020


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:1324
 
+static bool signBitNotSet(unsigned Val) { return (Val & 0x80000000) == 0; }
+
----------------
Shouldn't use unsigned here


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91336/new/

https://reviews.llvm.org/D91336



More information about the llvm-commits mailing list