[PATCH] D93189: [WIP] Introduce the `!nocapture` metadata and "nocapture_use" operand bundle

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Analysis/CaptureTracking.cpp:321
           return;
       }
       break;
----------------
nikic wrote:
> jdoerfert wrote:
> > Interestingly, we seem to not consider operand bundle uses to be capturing. This is (IMHO) wrong in general. "nocapure_use" does not capture but others should be assumed to do. Will propose a separate patch at some point.
> Data operands = Arguments + operand bundles, so this should also consider operand bundle uses.
Then I don't know why my local tests "work" as I add operand bundles but nocapture is deduced for things used in there. I'll have to look into this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93189/new/

https://reviews.llvm.org/D93189