[PATCH] D89845: Add the ability to extract the unwind rows from DWARF Call Frame Information.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp:448
+        errc::invalid_argument,
+        "op[%" PRIu32 "] has OperandType OT_Address which produces a unsigned "
+        "result, call getOperandAsUnsigned instead",
----------------
jhenderson wrote:
> 
Looks like you missed this comment?


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp:977-978
+  else
+    OS << "  error: decoding the CIE opcodes into rows failed: "
+       << toString(RowsOrErr.takeError()) << "\n";
+  OS << "\n";
----------------
jhenderson wrote:
> This sounds like it should be reported through an error handler, rather than printed into the main stream?
Ping this?


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp:1003
+  else
+    OS << "  error: decoding the CIE opcodes into rows failed: "
+       << toString(RowsOrErr.takeError()) << "\n";
----------------
jhenderson wrote:
> Same comment as above.
Ping this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89845/new/

https://reviews.llvm.org/D89845