[PATCH] D93161: [VE] Support atomic exchange instructions

Kazushi Marukawa via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 14 07:04:17 PST 2020


kaz7 added inline comments.


================
Comment at: llvm/lib/Target/VE/VEISelLowering.h:30-39
+  CALL,          // A call instruction.
+  GETFUNPLT,     // Load function address through %plt insturction.
+  GETTLSADDR,    // Load address for TLS access.
+  GETSTACKTOP,   // Retrieve address of stack top (first address of locals and
+                 // temporaries).
+  MEMBARRIER,    // Compiler barrier only; generate a no-op.
+  RET_FLAG,      // Return with a flag operand.
----------------
simoll wrote:
> Re-formatting this list is an unrelated change. We should do this in a separate commit.
Ok.  I'll revert it.


================
Comment at: llvm/lib/Target/VE/VERegisterInfo.cpp:28-29
 
+#define DEBUG_TYPE "ve-register-info"
+
 using namespace llvm;
----------------
simoll wrote:
> Also an unrelated change.
It is required to add L. 141.  But, I can remove L. 141.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93161/new/

https://reviews.llvm.org/D93161



More information about the llvm-commits mailing list