[PATCH] D93161: [VE] Support atomic exchange instructions

Simon Moll via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 14 06:40:55 PST 2020


simoll added a comment.

LGTM with nits.



================
Comment at: llvm/lib/Target/VE/VEISelLowering.h:30-39
+  CALL,          // A call instruction.
+  GETFUNPLT,     // Load function address through %plt insturction.
+  GETTLSADDR,    // Load address for TLS access.
+  GETSTACKTOP,   // Retrieve address of stack top (first address of locals and
+                 // temporaries).
+  MEMBARRIER,    // Compiler barrier only; generate a no-op.
+  RET_FLAG,      // Return with a flag operand.
----------------
Re-formatting this list is an unrelated change. We should do this in a separate commit.


================
Comment at: llvm/lib/Target/VE/VERegisterInfo.cpp:28-29
 
+#define DEBUG_TYPE "ve-register-info"
+
 using namespace llvm;
----------------
Also an unrelated change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93161/new/

https://reviews.llvm.org/D93161



More information about the llvm-commits mailing list