[PATCH] D93160: [X86] Fix variadic argument handling for x32

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:31557
+                                               MachineBasicBlock *MBB) const {
   // Emit va_arg instruction on X86-64.
 
----------------
hvdijk wrote:
> RKSimon wrote:
> > update comment
> This comment looks correct to me in its current form. I'm not sure if you mean to change va_arg or X86-64, but va_arg is the spelling that the LLVM IR instruction uses, and X86-64 includes both the LP64 and ILP32 ABIs. If I am missing something here, please let me know what.
OK - I was thinking that maybe we should explicitly mention that we're trying to handle x32 here as well - but I agree it was rather pedantic!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93160/new/

https://reviews.llvm.org/D93160