[PATCH] D93160: [X86] Fix variadic argument handling for x32
Harald van Dijk via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Dec 12 09:16:06 PST 2020
hvdijk added a comment.
In D93160#2450356 <https://reviews.llvm.org/D93160#2450356>, @RKSimon wrote:
> Its OK to commit the asm.py / update_llc_test_checks.py changes right away to split them from the rest of this patch
Thanks, done.
================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:31557
+ MachineBasicBlock *MBB) const {
// Emit va_arg instruction on X86-64.
----------------
RKSimon wrote:
> update comment
This comment looks correct to me in its current form. I'm not sure if you mean to change va_arg or X86-64, but va_arg is the spelling that the LLVM IR instruction uses, and X86-64 includes both the LP64 and ILP32 ABIs. If I am missing something here, please let me know what.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93160/new/
https://reviews.llvm.org/D93160
More information about the llvm-commits
mailing list