[PATCH] D92068: [MachineCombiner] [NFC]Add MustReduceRegisterPressure goal
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Dec 12 09:05:55 PST 2020
spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/include/llvm/CodeGen/TargetInstrInfo.h:1068
+
+ /// Return true if target supports ressociation of instrucitons in machine
+ /// combiner pass to reduce register pressure for a given BB.
----------------
Spelling is still wrong here:
ressociation -> reassociation
instrucitons -> instructions
================
Comment at: llvm/lib/CodeGen/MachineCombiner.cpp:478
+ // Otherwise the constant pool entry created for InsInstrs will not be deleted
+ // even if InsInstrs is not the bettern pattern.
+ TII->finalizeInsInstrs(MI, Pattern, InsInstrs);
----------------
bettern -> better
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92068/new/
https://reviews.llvm.org/D92068
More information about the llvm-commits
mailing list