[PATCH] D92068: [MachineCombiner] [NFC]Add MustReduceRegisterPressure goal

Thu Dec 10 23:36:57 PST 2020

shchenz added a comment.

In D92068#2446159 <https://reviews.llvm.org/D92068#2446159>, @spatel wrote:

> If this is NFC now, no objections from me - I just noted minor errors.
> So we do not need LiveIntervals analysis at all now to reduce pressure, or that will be dealt with separately?

Thanks for your careful review. Updated accordingly.
Now I only handle two patterns in PowerPC patch https://reviews.llvm.org/D92071. The left patterns hit in our internal tests don't need live intervals analysis to decide the specific blocks are in high register pressure.
And yes, I will handle the other two deleted patterns which require live intervals analysis in following patches. I will keep in mind live intervals analysis should only be run on targets that use this newly added goal. ^^

Thanks again for making this patch go so far.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92068/new/

https://reviews.llvm.org/D92068