[PATCH] D76519: [NFC] Refactor how CFI move sections are represented in AsmPrinter

Fri Dec 11 14:36:23 PST 2020

scott.linder added a comment.

In D76519#2449652 <https://reviews.llvm.org/D76519#2449652>, @MaskRay wrote:

> Thanks for refactoring it:) I dug up a bit of history. @asl introduced the variable `shouldEmitMoves` in rL123474 <https://reviews.llvm.org/rL123474> and espindola introduced the member function `needsCFIMoves`.
> I cannot find "CFI move section" in standards so it is probably not a standard term. Should we use a more appropriate term to best capture the intention?

I don't know if there is a generally accepted term to encompass .debug_frame+.eh_frame? Maybe just "CFI section"? Or "section containing CFI"?

I can change the shortlog message to:

  [NFC] Refactor AsmPrinter tracking of CFI sections

And the comment to:

  // Flags representing which sections to emit CFI to.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76519/new/

https://reviews.llvm.org/D76519