[PATCH] D76519: [NFC] Refactor how CFI move sections are represented in AsmPrinter

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 11 13:40:14 PST 2020


MaskRay added a subscriber: asl.
MaskRay added a comment.

Thanks for refactoring it:) I dug a bit of history. @asl introduced the variable `shouldEmitMoves` in rL123474 <https://reviews.llvm.org/rL123474> and espindola introduced the member function `needsCFIMoves`.
I cannot find "CFI move section" in standards so it probably is not a standard term. Should we use a more appropriate term to best capture the intention?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76519/new/

https://reviews.llvm.org/D76519



More information about the llvm-commits mailing list