[PATCH] D93033: [llvm-readobj] - For SHT_REL relocations, don't display an addend.

[Alexander Richardson via Phabricator via llvm-commits]

arichardson accepted this revision.
arichardson added a comment.

In D93033#2447955 <https://reviews.llvm.org/D93033#2447955>, @grimar wrote:

> In D93033#2445785 <https://reviews.llvm.org/D93033#2445785>, @arichardson wrote:
>
>> My only concern about removing the 0x0 from the CHECK lines is that these tests will still pass if we do add support for reading REL addends. I see that many of the tests now contain `{{$}}`, maybe add this for all of them?
>
> I've updated those that are related to llvm-readobj (i.e. tests from `test/tools/llvm-readobj`). I haven't updated others because they are not testing llvm-readobj output or relocation addend values (they were always 0x0 previously,
> what is simply wrong technically). Given that I feel that spreading of `{{$}}` past the `test/tools/llvm-readobj` folder  is perhaps a bit excessive.

I only skimmed the testsuite changes and didn't notice that this was deliberate based on the folder. Adding `{{$}}` it in test/tools/llvm-readobj only makes sense to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93033/new/

https://reviews.llvm.org/D93033