[PATCH] D92507: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives

Eric Astor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 10 07:07:19 PST 2020


epastor added a comment.

In D92507#2431130 <https://reviews.llvm.org/D92507#2431130>, @thakis wrote:

> Does it wrap around 32-bit in 64-bit output too?

Oddly enough: yes.

> Is this relied on? Or could we error out on negative values instead?

I don't think we can prove that it isn't relied on, especially when ORG explicitly allows putting things "outside bounds", so I'd rather maintain compatibility.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92507/new/

https://reviews.llvm.org/D92507



More information about the llvm-commits mailing list