[PATCH] D93013: [RISCV] Define vadd intrinsics and lower to V instructions.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1017
+        assert(II->ExtendedOperand < Op.getNumOperands());
+        std::vector<SDValue> Operands(Op->op_begin(), Op->op_end());
+        SDValue &ScalarOp = Operands[II->ExtendedOperand];
----------------
Use SmallVector with the expected number of operands.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1022
+            ScalarOp.getValueType() == MVT::i32) {
+          ScalarOp = DAG.getNode(ISD::ANY_EXTEND, DL, MVT::i64, ScalarOp);
+          return DAG.getNode(ISD::INTRINSIC_WO_CHAIN, DL, Op.getValueType(),
----------------
MVT::i64 here should be Subtarget->XLenVT() I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93013/new/

https://reviews.llvm.org/D93013