[PATCH] D91611: [PowerPC][LLD] Detecting and fixing missing TLS relocation on __tls_get_addr

Thu Dec 10 13:16:15 PST 2020

stefanp added a comment.

In D91611#2446779 <https://reviews.llvm.org/D91611#2446779>, @MaskRay wrote:

> In D91611#2446331 <https://reviews.llvm.org/D91611#2446331>, @stefanp wrote:
>
>> In D91611#2443178 <https://reviews.llvm.org/D91611#2443178>, @MaskRay wrote:
>>
>>> I think the code should be extracted to `scanRelocs`: check whether there are R_TLSGD_GOT relocations without R_PPC64_TLSGD/R_PPC64_TLSLD. This may be an entire rewrite. I'm working on it.
>>
>> I think I understand what you are looking for. It's my patch so I should probably be doing the rewrite myself.
>> I don't want you to spend more time than you have to on this...
>
> ... but do you think D92959 <https://reviews.llvm.org/D92959> is complete now?

Yes, I see you have already written it.
Thank you for your help.
In that case I'll move to your patch and add comments there.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91611/new/

https://reviews.llvm.org/D91611