[PATCH] D91611: [PowerPC][LLD] Detecting and fixing missing TLS relocation on __tls_get_addr

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 10 12:40:25 PST 2020


MaskRay added a comment.

In D91611#2446331 <https://reviews.llvm.org/D91611#2446331>, @stefanp wrote:

> In D91611#2443178 <https://reviews.llvm.org/D91611#2443178>, @MaskRay wrote:
>
>> I think the code should be extracted to `scanRelocs`: check whether there are R_TLSGD_GOT relocations without R_PPC64_TLSGD/R_PPC64_TLSLD. This may be an entire rewrite. I'm working on it.
>
> I think I understand what you are looking for. It's my patch so I should probably be doing the rewrite myself.
> I don't want you to spend more time than you have to on this...

... but do you think D92959 <https://reviews.llvm.org/D92959> is complete now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91611/new/

https://reviews.llvm.org/D91611



More information about the llvm-commits mailing list