[PATCH] D92840: [WebAssembly] call_indirect causes indirect function table import

Wed Dec 9 16:05:41 PST 2020

aheejin added inline comments.

================
Comment at: llvm/lib/Target/WebAssembly/AsmParser/CMakeLists.txt:7
   MCParser
+  WebAssemblyCodeGen
   WebAssemblyInfo
----------------
sbc100 wrote:
> It could be that MC may be designed to specifically not include CodeGen stuff?  Separation of concerns and all that.
> 
> Perhaps this oversteps some boundary?  I'm not familiar enough the design goals of llvm WRT compartmentalization to know if this is some kind of violation.  Does anyone know if this is problem?
> 
I don't know; I just discovered the linking works that way, but I'm not sure whether it violates some LLVM convention or something. Other AsmParser directories don't seem to make use of their corresponding CodeGen libraries though.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92840/new/

https://reviews.llvm.org/D92840