[PATCH] D92840: [WebAssembly] call_indirect causes indirect function table import

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 9 10:07:21 PST 2020


sbc100 added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/AsmParser/CMakeLists.txt:7
   MCParser
+  WebAssemblyCodeGen
   WebAssemblyInfo
----------------
It could be that MC may be designed to specifically not include CodeGen stuff?  Separation of concerns and all that.

Perhaps this oversteps some boundary?  I'm not familiar enough the design goals of llvm WRT compartmentalization to know if this is some kind of violation.  Does anyone know if this is problem?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92840/new/

https://reviews.llvm.org/D92840



More information about the llvm-commits mailing list