[PATCH] D92488: [LICM] Add a maximum for the number of instructions to be hoisted

Tue Dec 8 04:02:53 PST 2020

SjoerdMeijer added a comment.

Thanks for the feedback.

In D92488#2437692 <https://reviews.llvm.org/D92488#2437692>, @reames wrote:

> Hard reject.  This patch will not be accepted.  This is a major design change.
>
> Hoisting operations out of loops is treated as a canonicalization transform in LLVM.

I have documented this in https://reviews.llvm.org/rG1e260f955d31.

> If the register pressure is problematic, the MachineLICM pass is supposed to undo the transformation.  If you have cases where that is not happening, please explore why.

Thanks for the pointer, will do.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92488/new/

https://reviews.llvm.org/D92488