[PATCH] D92488: [LICM] Add a maximum for the number of instructions to be hoisted

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 7 13:36:01 PST 2020


asbirlea added a comment.

In D92488#2437692 <https://reviews.llvm.org/D92488#2437692>, @reames wrote:

> Hard reject.  This patch will not be accepted.  This is a major design change.
>
> Hoisting operations out of loops is treated as a canonicalization transform in LLVM.  If the register pressure is problematic, the MachineLICM pass is supposed to undo the transformation.  If you have cases where that is not happening, please explore why.
>
> If after doing so, you still feel this is the right approach, please raise the design change on llvm-dev.

+1


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92488/new/

https://reviews.llvm.org/D92488



More information about the llvm-commits mailing list