[PATCH] D92465: [PowerPC] Implement intrinsic for DARN instruction

Qing Shan Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 7 19:30:14 PST 2020


steven.zhang added a comment.

In D92465#2438652 <https://reviews.llvm.org/D92465#2438652>, @qiucf wrote:

> In D92465#2438602 <https://reviews.llvm.org/D92465#2438602>, @steven.zhang wrote:
>
>> LGTM.
>
> Thanks for reviewing! Maybe we need a predicate to guard it to prevent generating it on `P8` or earlier targets? And as I see for other intrinsics (for example, `dcbfps`), if current platform doesn't support it, `llc` would crash and say `LLVM ERROR: Cannot select: intrinsic %llvm.ppc.dcbfps`. This is expected, but is there some way to express normal error to user instead of internal crash?

Yes, it should be guarded. But please leave the LLVM ERROR alone as it is by design I think.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92465/new/

https://reviews.llvm.org/D92465



More information about the llvm-commits mailing list