[PATCH] D92465: [PowerPC] Implement intrinsic for DARN instruction

[Qiu Chaofan via Phabricator via llvm-commits]

qiucf added a comment.

In D92465#2438602 <https://reviews.llvm.org/D92465#2438602>, @steven.zhang wrote:

> LGTM.

Thanks for reviewing! Maybe we need a predicate to guard it to prevent generating it on `P8` or earlier targets? And as I see for other intrinsics (for example, `dcbfps`), if current platform doesn't support it, `llc` would crash and say `LLVM ERROR: Cannot select: intrinsic %llvm.ppc.dcbfps`. This is expected, but is there some way to express normal error to user instead of internal crash?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92465/new/

https://reviews.llvm.org/D92465