[PATCH] D92755: [YAML] Support extended spellings when parsing bools.

[Nathan James via Phabricator via llvm-commits]

njames93 added a comment.

Also I may need to investigate the pre-merge, some tests were failing, some looked like they involved yaml and are related to this. Keys called `N` were missing because the parser was treating them as a bool it seems. Will let it build again to be sure it is this patch causing the issue.



================
Comment at: llvm/unittests/Support/YAMLParserTest.cpp:356
+TEST(YAMLParser, ParsesBools) {
+  expectCanParseBool("True", true);
+  expectCanParseBool("true", true);
----------------
silvas wrote:
> Nit: I find these a little hard to scan. Can we separate the "true" and "false" cases with comments, and then sort within each one (it's not obvious to me how the current ones are sorted).
I'm a little lost in what you are asking. Comments where exactly?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92755/new/

https://reviews.llvm.org/D92755