[PATCH] D92755: [YAML] Support extended spellings when parsing bools.

Sean Silva via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 7 12:26:31 PST 2020


silvas accepted this revision.
silvas added a comment.
This revision is now accepted and ready to land.

Thanks. This LGTM.



================
Comment at: llvm/unittests/Support/YAMLParserTest.cpp:356
+TEST(YAMLParser, ParsesBools) {
+  expectCanParseBool("True", true);
+  expectCanParseBool("true", true);
----------------
Nit: I find these a little hard to scan. Can we separate the "true" and "false" cases with comments, and then sort within each one (it's not obvious to me how the current ones are sorted).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92755/new/

https://reviews.llvm.org/D92755



More information about the llvm-commits mailing list