[PATCH] D91156: [AArch64] Compiler-rt interface for out-of-line atomics.

[Pavel Iliin via Phabricator via llvm-commits]

ilinpv added inline comments.


================
Comment at: compiler-rt/lib/builtins/CMakeLists.txt:521
+      if(pat STREQUAL "cas" OR NOT size STREQUAL "16")
+        set(helper_asm outline_atomic_${pat}${size}_${model}.S)
+        add_custom_command(
----------------
mstorsjo wrote:
> ilinpv wrote:
> > mstorsjo wrote:
> > > These generated templated files end up placed directly in the root of the builddir (when building standalone, with cmake pointing at compiler-rt/lib/builtins) which I find a bit unusual. Could some subdir be made for them to avoid cluttering the build dir too much?
> > > 
> > Yes, if it is more convenient I can create subdir like 'outline_atomic_helpers' for them
> Yeah, something like that sounds good to me.
Patch for that is here: https://reviews.llvm.org/D92724


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91156/new/

https://reviews.llvm.org/D91156