[PATCH] D91156: [AArch64] Compiler-rt interface for out-of-line atomics.

Thu Dec 3 04:42:41 PST 2020

mstorsjo added a comment.

In D91156#2430880 <https://reviews.llvm.org/D91156#2430880>, @ilinpv wrote:

> In D91156#2430422 <https://reviews.llvm.org/D91156#2430422>, @mstorsjo wrote:
>
>> Also, I see that this wasn't actually sent to any mailing list - I guess we should have some list auto-added for anything touching compiler-rt?
>
> Plans and questions were sent to llvm-dev http://lists.llvm.org/pipermail/llvm-dev/2020-October/145841.html.

Fair enough, but despite that, afaik the individual patch reviews still should have a public list set as subscriber by principle (either llvm-commits, cfe-commits or libcxx-commits). This becomes a bit easier to miss by the fact that such lists are automatically added as subscribers for certain subprojects, but apparently not for compiler-rt. (Also - even if the patch reviews had been sent to the list, I most certainly wouldn't have picked up and commented on them.)

================
Comment at: compiler-rt/lib/builtins/CMakeLists.txt:521
+      if(pat STREQUAL "cas" OR NOT size STREQUAL "16")
+        set(helper_asm outline_atomic_${pat}${size}_${model}.S)
+        add_custom_command(
----------------
ilinpv wrote:
> mstorsjo wrote:
> > These generated templated files end up placed directly in the root of the builddir (when building standalone, with cmake pointing at compiler-rt/lib/builtins) which I find a bit unusual. Could some subdir be made for them to avoid cluttering the build dir too much?
> > 
> Yes, if it is more convenient I can create subdir like 'outline_atomic_helpers' for them
Yeah, something like that sounds good to me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91156/new/

https://reviews.llvm.org/D91156