[PATCH] D92621: [SampleFDO] Store fixed length MD5 in NameTable instead of using ULEB128 if MD5 is used.

Wei Mi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 4 16:28:14 PST 2020


wmi added inline comments.


================
Comment at: llvm/lib/ProfileData/SampleProfReader.cpp:372
+  // read NameTable index.
+  auto Idx = readMD5StringIndex();
+  if (std::error_code EC = Idx.getError())
----------------
hoy wrote:
> Can this be just `readStringIndex(NameTable)`  since `NameTable` is preallocated?
Good point. That makes the code simpler. 


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92621/new/

https://reviews.llvm.org/D92621



More information about the llvm-commits mailing list