[PATCH] D92621: [SampleFDO] Store fixed length MD5 in NameTable instead of using ULEB128 if MD5 is used.

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 4 15:00:31 PST 2020


hoy added inline comments.


================
Comment at: llvm/lib/ProfileData/SampleProfReader.cpp:372
+  // read NameTable index.
+  auto Idx = readMD5StringIndex();
+  if (std::error_code EC = Idx.getError())
----------------
Can this be just `readStringIndex(NameTable)`  since `NameTable` is preallocated?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92621/new/

https://reviews.llvm.org/D92621



More information about the llvm-commits mailing list