[PATCH] D92612: [MC] Consume EndOfStatement in .cfi_{sections,endproc}

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 4 12:29:12 PST 2020


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: llvm/test/MC/ELF/cfi.s:439
+
+// RUN: not llvm-mc -triple=x86_64 -o - -defsym=ERR=1 %s 2>&1 | FileCheck %s --check-prefix=ERR
+
----------------
I think it is more common to place RUN lines above all the CHECK lines.

MC/ELF does have some parser tests (-filetype=asm).  I agree that the organization of tests is a bit unclear but I think MC/ELF for these .cfi_* is fine because they are indeed specific to certain binary formats.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92612/new/

https://reviews.llvm.org/D92612



More information about the llvm-commits mailing list