[PATCH] D92612: [MC] Consume EndOfStatement in .cfi_{sections,endproc}

[Scott Linder via Phabricator via llvm-commits]

scott.linder added inline comments.


================
Comment at: llvm/test/MC/AsmParser/directive-parse-err.s:1
+// RUN: not llvm-mc -triple i386-unknown-unknown %s 2>&1 | FileCheck %s
+// RUN: not llvm-mc -triple i386-unknown-unknown %s 2>&1 | grep "error:" | count 6
----------------
MaskRay wrote:
> scott.linder wrote:
> > MaskRay wrote:
> > > Please merge this into a `.cfi_*` parsing test. You can leverage `-defsym ERR=1` to check errors. See `MC/ELF/reloc-directive.s` for an example
> > To clarify, is there an "omnibus" cfi parsing test under `MC/AsmParser`? I see a few specific examples, but not just `cfi.s`. Did you have a particular test in mind?
> They don't have to be under `MC/AsmParser`. You may use `MC/ELF` where there are a few `cfi*.s`
Ok, it just seemed like tests under `ELF/` were for the binary result, not necessarily for the behavior of the parser directly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92612/new/

https://reviews.llvm.org/D92612