[PATCH] D91362: [SelectionDAG] Add llvm.vector.{extract,insert} intrinsics

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 4 09:54:24 PST 2020


cameron.mcinally accepted this revision.
cameron.mcinally added a subscriber: ctetreau.
cameron.mcinally added a comment.
This revision is now accepted and ready to land.

LGTM

I think @ctetreau's "first class citizen" argument on the RFC has merit though. But this patch is a good first step if we're not ready to extend ShuffleVector yet. I personally would like to see ShuffleVector extended eventually, since it would be easier to optimize.

@ctetreau's RFC comment can be found here:

http://lists.llvm.org/pipermail/llvm-dev/2020-December/146981.html


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91362/new/

https://reviews.llvm.org/D91362



More information about the llvm-commits mailing list