[PATCH] D92582: [AArch64][GlobalISel] Refactor G_BRCOND selection
Amara Emerson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 3 20:50:47 PST 2020
aemerson accepted this revision.
aemerson added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp:1572-1579
+ switch (CCMI->getOpcode()) {
+ default:
+ break;
+ case TargetOpcode::G_FCMP:
+ return selectCompareBranchFedByFCmp(I, *CCMI, MIB);
+ case TargetOpcode::G_ICMP:
+ return selectCompareBranchFedByICmp(I, *CCMI, MIB);
----------------
This seems a bit overkill for just 2 cases, just use 2 if()s?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92582/new/
https://reviews.llvm.org/D92582
More information about the llvm-commits
mailing list