[PATCH] D92539: [lld-macho] Support parsing of bitcode within archives

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 3 15:18:30 PST 2020


int3 added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:623
+  InputFile *file;
+  switch (identify_magic(mb.getBuffer())) {
+  case file_magic::macho_object:
----------------
thakis wrote:
> nit: other ports have a `isBitcode()` in InputFiles.h instead and call that here and assume obj if that returns false
Isn't it better to have more precise error handling though?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92539/new/

https://reviews.llvm.org/D92539



More information about the llvm-commits mailing list