[PATCH] D92539: [lld-macho] Support parsing of bitcode within archives

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 3 06:22:17 PST 2020


thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Conceptually lg, but I think it'd be good if we try to keep the various ports looking alike (in this case, probably like COFF/InputFiles.cpp).



================
Comment at: lld/MachO/InputFiles.cpp:623
+  InputFile *file;
+  switch (identify_magic(mb.getBuffer())) {
+  case file_magic::macho_object:
----------------
nit: other ports have a `isBitcode()` in InputFiles.h instead and call that here and assume obj if that returns false


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92539/new/

https://reviews.llvm.org/D92539



More information about the llvm-commits mailing list