[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

[Albion Fung via Phabricator via llvm-commits]

Conanap added a comment.

addressed a comment



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:9366
+        SplatNode = DAG.getNode(
+            PPCISD::XXSPLTI32DX, SDLoc(SplatNode), MVT::v2i64, SplatNode,
+            DAG.getTargetConstant(isLE ? 1 : 0, SplatNode, MVT::i32),
----------------
amyk wrote:
> I think I'm still a little confused by this. Do we not need `dl` when we do `getNode()` here?
Hey so the DL is supplied from `SplatNode`'s definition, and then we pass in `SDLoc(SplatNode)` here as the proper SDLoc after new instr def.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90173/new/

https://reviews.llvm.org/D90173