[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

[Amy Kwan via Phabricator via llvm-commits]

amyk added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:9357
+
+      if (Lo) {
+        SplatNode =
----------------
Braces can be omitted here and on 9364 if it's just a single statement.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:9366
+        SplatNode = DAG.getNode(
+            PPCISD::XXSPLTI32DX, SDLoc(SplatNode), MVT::v2i64, SplatNode,
+            DAG.getTargetConstant(isLE ? 1 : 0, SplatNode, MVT::i32),
----------------
I think I'm still a little confused by this. Do we not need `dl` when we do `getNode()` here?


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:2385
+
+  def : Pat <(v2i64 (PPCxxsplti32dx v2i64:$XT, i32:$XI, i32:$IMM32)),
+             (v2i64 (XXSPLTI32DX v2i64:$XT, i32:$XI, i32:$IMM32))>;
----------------
It would be good to put this under the "Anonymous Patterns" section.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90173/new/

https://reviews.llvm.org/D90173