[PATCH] D92147: [RISCV] Add support for printing pcrel immediates as absolute addresses in llvm-objdump

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 3 10:20:51 PST 2020


MaskRay added inline comments.


================
Comment at: lld/test/ELF/riscv-undefined-weak.s:55-56
 # PC-NEXT:     jalr -368(ra)
 ## FIXME: llvm-objdump -d should print the address, instead of the offset.
-# PC-NEXT:     j -70008
+# PC-NEXT:     j 0x0
 
----------------
luismarques wrote:
> Does the printing change address that FIXME? That is, isn't `0x0` the address? (which is zero because the relocation hasn't yet been applied).
Right. The FIXME should be deleted.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92147/new/

https://reviews.llvm.org/D92147



More information about the llvm-commits mailing list