[PATCH] D92147: [RISCV] Add support for printing pcrel immediates as absolute addresses in llvm-objdump

Thu Dec 3 02:22:01 PST 2020

luismarques added a comment.

We've been pretty consistent with trying to align our behaviour with the GNU tools, so these kinds of patches have always been welcome. I'm not sure if there are compatibility concerns with changing the behaviour now. Should we have a an option for changing the printing style, both for compatibility and personal preference?
About the verification, I'm not sure what the best approach is.

================
Comment at: lld/test/ELF/riscv-undefined-weak.s:55-56
 # PC-NEXT:     jalr -368(ra)
 ## FIXME: llvm-objdump -d should print the address, instead of the offset.
-# PC-NEXT:     j -70008
+# PC-NEXT:     j 0x0

----------------
Does the printing change address that FIXME? That is, isn't `0x0` the address? (which is zero because the relocation hasn't yet been applied).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92147/new/

https://reviews.llvm.org/D92147