[PATCH] D92412: [DebugInfo] Add handling of stringLengthExp operand of DIStringType

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:702
+    DIEDwarfExpression DwarfExpr(*Asm, getCU(), *Loc);
+    DwarfExpr.setMemoryLocationKind();
+    DwarfExpr.addExpression(Expr);
----------------
This would benefit from a comment explaining why forcing MemoryLocationKind is correct here.


================
Comment at: llvm/test/DebugInfo/X86/distringtype.ll:12
+; CHECK:                          DW_AT_name  (".str.DEFERRED")
+; CHECK-NEXT:                     DW_AT_string_length
+; CHECK:       DW_TAG_string_type
----------------
can you check the contents of the  DW_AT_string_length attribute, too?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92412/new/

https://reviews.llvm.org/D92412