[PATCH] D92412: [DebugInfo] Add handling of stringLengthExp operand of DIStringType

Chih-Ping Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 1 11:21:19 PST 2020


cchen15 added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:696
 
   if (DIVariable *Var = STy->getStringLength()) {
     if (auto *VarDIE = getDIE(Var))
----------------
Can we consolidate stringLength and stringLengthExp into one operand? It seems to me that a DIStringType can have one or the other, but not both.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92412/new/

https://reviews.llvm.org/D92412



More information about the llvm-commits mailing list