[PATCH] D92509: ADT: Remove redundant `alignas` from IntervalMap, NFC

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 2 13:56:47 PST 2020


dexonsmith added a reviewer: rnk.
dexonsmith added a subscriber: rnk.
dexonsmith added a comment.

In D92509#2429385 <https://reviews.llvm.org/D92509#2429385>, @dexonsmith wrote:

> @aleksandr.urakov , looking at history, this is effectively a revert of 379daa29744cd96b0a87ed0d4a010fa4bc47ce73 / r344027 / https://reviews.llvm.org/D52613. I don't totally understand why you needed `LLVM_ALIGNAS` here, since `AlignedCharArrayUnion` is supposed to handle that. Can you clarify?
>
> And if it's needed here, why not on all other instances of `AlignedCharArrayUnion`?

@rnk, you reviewed the original patch, maybe you have more background.

The original patch points at https://docs.microsoft.com/en-us/cpp/build/conflicts-with-the-x86-compiler which now gives 404. We dropped some older versions of MSCV when we moved to C++14; I wonder if whatever the need was, it's gone.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92509/new/

https://reviews.llvm.org/D92509



More information about the llvm-commits mailing list