[PATCH] D92509: ADT: Remove redundant `alignas` from IntervalMap, NFC

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 2 13:53:52 PST 2020


dexonsmith added a reviewer: aleksandr.urakov.
dexonsmith added a subscriber: aleksandr.urakov.
dexonsmith added a comment.

@aleksandr.urakov , looking at history, this is effectively a revert of 379daa29744cd96b0a87ed0d4a010fa4bc47ce73 / r344027 / https://reviews.llvm.org/D52613. I don't totally understand why you needed `LLVM_ALIGNAS` here, since `AlignedCharArrayUnion` is supposed to handle that. Can you clarify?

And if it's needed here, why not on all other instances of `AlignedCharArrayUnion`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92509/new/

https://reviews.llvm.org/D92509



More information about the llvm-commits mailing list