[PATCH] D92407: [ScalarizeMaskedMemIntrinsic] Move from CodeGen into Transforms

[Anna Thomas via Phabricator via llvm-commits]

anna added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Scalar/ScalarizeMaskedMemIntrin.h:23
+#include "llvm/Pass.h"
+#include "llvm/Transforms/Scalar/ScalarizeMaskedMemIntrin.h"
+
----------------
craig.topper wrote:
> Is this including itself?
ugh. yes.


================
Comment at: llvm/include/llvm/Transforms/Scalar/ScalarizeMaskedMemIntrin.h:27
+
+class ScalarizeMaskedMemIntrin : public FunctionPass {
+  const TargetTransformInfo *TTI = nullptr;
----------------
craig.topper wrote:
> It looks like most of Transforms/Scalar only has header files for the new pass manager class. Not the legacy pass manager class.
that's true (and the legacy PM classes are in the cpp files). However, I left this in here because:
1. there no new PM support yet
2. When new PM is added (will be the next change), we will need a header file anyway
3. I'd added this header file in PassBuilder.h.... now I realize that's part of the new PM infrastructure and hence not needed in this patch.

Given I've mixed both "moving the pass into middle end and new PM support", I'm going to avoid the header file in this change and just do the move into the `transforms/scalar` directory.
The header file and PassBuilder change will be as part of new PM support.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92407/new/

https://reviews.llvm.org/D92407