[PATCH] D92407: [ScalarizeMaskedMemIntrinsic] Move from CodeGen into Transforms

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Scalar/ScalarizeMaskedMemIntrin.h:19
+
+#include "llvm/Analysis/TargetTransformInfo.h"
+#include "llvm/IR/BasicBlock.h"
----------------
Someone of these could probably just be replaced with forward declarations.


================
Comment at: llvm/include/llvm/Transforms/Scalar/ScalarizeMaskedMemIntrin.h:23
+#include "llvm/Pass.h"
+#include "llvm/Transforms/Scalar/ScalarizeMaskedMemIntrin.h"
+
----------------
Is this including itself?


================
Comment at: llvm/include/llvm/Transforms/Scalar/ScalarizeMaskedMemIntrin.h:27
+
+class ScalarizeMaskedMemIntrin : public FunctionPass {
+  const TargetTransformInfo *TTI = nullptr;
----------------
It looks like most of Transforms/Scalar only has header files for the new pass manager class. Not the legacy pass manager class.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92407/new/

https://reviews.llvm.org/D92407