[PATCH] D92324: [PowerPC] Fix altivec feature on pwr cpus pre pwr6.

Wed Dec 2 07:34:38 PST 2020

hubert.reinterpretcast added inline comments.

================
Comment at: llvm/lib/Target/PowerPC/PPC.td:532-533
+// but that did not appear in any IBM systems. While VMX/Altivec was added in
+// ISA 2.03 (pwr4), the extension was optional. The first IBM processor with
+// Altivec implemented in an IBM system was Power6.
 def : ProcessorModel<"pwr3", G5Model,
----------------
sfertile wrote:
> hubert.reinterpretcast wrote:
> > Remove the last sentence here.
> I think we need to keep a comment indicating the Power Systems didn't implement the optional extension to avoid having them enabled again in the future.  
Yup, that's fine. I saw that you changed it to say "IBM Power system", which I guess is correct (the QS blade servers are "Cell BE" as opposed to "Power" systems).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92324/new/

https://reviews.llvm.org/D92324