[PATCH] D89566: [LV] Epilogue Vectorization with Optimal Control Flow

Wed Dec 2 07:15:15 PST 2020

bmahjour added a comment.

> OK great. It sounds like there's agreement on the further direction overall and we can work on that in-tree. I'll work on getting the pieces ready to handle live-ins/live-outs in VPlan as required. As for the sekeleton creator, I might be able to take a look over the next week.
>
> LGTM, thanks (meant to respond a bit earlier today :)

Sounds good. If I get a chance to work on skeleton builder I'll let you know before hand to make sure we don't work on it at the same time. Otherwise I'd be happy to help with the review. Thanks!

================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:159
 #define DEBUG_TYPE LV_NAME
+static const char *VerboseDebug = DEBUG_TYPE "-verbose";

----------------
MaskRay wrote:
> This variable is mutable.
> 
> Please use `constexpr char VerboseDebug[]` or `const char VerboseDebug[]`. Namespace-scoped const variables are already internal, no need for `static`
> 
> Please also use `#ifndef NDEBUG` to avoid -Wunused-variable in -DLLVM_ENABLE_ASSERTIONS=off builds
Right, made the changes in the latest commit. Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89566/new/

https://reviews.llvm.org/D89566