[PATCH] D89566: [LV] Epilogue Vectorization with Optimal Control Flow
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 1 10:04:57 PST 2020
MaskRay added inline comments.
================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:159
#define DEBUG_TYPE LV_NAME
+static const char *VerboseDebug = DEBUG_TYPE "-verbose";
----------------
This variable is mutable.
Please use `constexpr char VerboseDebug[]` or `const char VerboseDebug[]`. Namespace-scoped const variables are already internal, no need for `static`
Please also use `#ifndef NDEBUG` to avoid -Wunused-variable in -DLLVM_ENABLE_ASSERTIONS=off builds
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89566/new/
https://reviews.llvm.org/D89566
More information about the llvm-commits
mailing list