[PATCH] D84873: AMDGPU: In determining load clobbering in AnnotateUniform, don't scan if there are too many blocks.

Changpeng Fang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 1 16:04:00 PST 2020


cfang added a comment.

In D84873#2358999 <https://reviews.llvm.org/D84873#2358999>, @arsenm wrote:

> In D84873#2357528 <https://reviews.llvm.org/D84873#2357528>, @cfang wrote:
>
>> Ping!
>>
>> Should we commit this patch to fix the compilation time for now? Then we may look at the possibility to replace 
>> MemoryDependenceAnaysis in AnnotateUniform pass?
>
> This doesn't sound like a commitment to me

Do you mean we need to open a bug (new task) to redesign load clobbering in  AnnotateUniform pass?
Given the current implementation, I think this proposal is an effective cut-off to an expensive searching (without caching).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84873/new/

https://reviews.llvm.org/D84873



More information about the llvm-commits mailing list